Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #531] Don't match strings when using clojure-rename-ns-alias. #534

Merged
merged 1 commit into from Jul 10, 2019

Conversation

anthonygalea
Copy link
Contributor

Is it acceptable to use font locking to determine whether a string was matched?

  • The commits are consistent with our [contribution guidelines][1].
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

@bbatsov
Copy link
Member

bbatsov commented Jul 10, 2019

Is it acceptable to use font locking to determine whether a string was matched?

Generally it's better to use syntax-ppss (https://www.gnu.org/software/emacs/manual/html_node/elisp/Position-Parse.html)

@anthonygalea
Copy link
Contributor Author

thanks @bbatsov

@bbatsov bbatsov merged commit 2691626 into clojure-emacs:master Jul 10, 2019
@bbatsov
Copy link
Member

bbatsov commented Jul 10, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants