Accept cons pair for tcp connections. #34
Conversation
| @@ -322,7 +322,9 @@ of `inf-clojure-program'). Runs the hooks from | |||
| (if (not (comint-check-proc "*inf-clojure*")) | |||
| ;; run the new process in the project's root when in a project folder | |||
| (let ((default-directory (inf-clojure-project-root)) | |||
| (cmdlist (split-string cmd))) | |||
| (cmdlist (if (consp cmd) | |||
There was a problem hiding this comment.
I'm guessing the related defcustom should be updated as well.
mahinshaw
force-pushed
the
socket-connection
branch
from
184f0a6
to
1d2bf1d
Compare
|
Sorry about that. I updated the defcustom. |
|
Btw, what exactly is the reasoning behind this change? I'm guessing that I'm not 100% certain what are you trying to achieve here. |
|
I was trying to connect to a clojure socket repl. And since a cons pair for tcp connections is part of the comint API, it made sense to leverage that option. |
|
Got it. Well, I guess you should make this a bit more explicit in the |
mahinshaw
force-pushed
the
socket-connection
branch
from
1d2bf1d
to
7f82c3a
Compare
|
@bbatsov I updated the defcustom doc string, and the readme. Let me know if that description is what you are looking for. |
|
👍 |
|
Btw, see #44 - I think we can extend this to something that would offer a much better planck support out-of-the-box |
Coming takes a cons pair for connecting to tcp connections. This allows
inf-clojure(or settinginf-clojure-program) to accept a cons pair for connecting to a clojure socket repl server. I tested this with planck viaplanck -n 5555.