Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop cheshire for clojure.data.json #306

Closed
expez opened this issue Jun 27, 2021 · 0 comments
Closed

Drop cheshire for clojure.data.json #306

expez opened this issue Jun 27, 2021 · 0 comments

Comments

@expez
Copy link
Member

expez commented Jun 27, 2021

We've had some issues with cheshire in the past. It's also a library with a ton of dependencies compared to clojure.data.json which is entirely self-contained.

clojure.data.json recently went through a round of performance tuning and is now faster than cheshire on some payloads and within spitting distance on most others.

The big payload from clojars is read as edn and cheshire is only used on the comparatively small payloads for maven central. I expect this change to:

  1. Making parse an insignificant amount faster
  2. Make our jar smaller
  3. Make it less likely that we cause dependency problems in the future
expez added a commit that referenced this issue Jul 1, 2021
vemv pushed a commit that referenced this issue Jul 1, 2021
vemv pushed a commit that referenced this issue Jul 1, 2021
vemv pushed a commit that referenced this issue Jul 1, 2021
vemv pushed a commit that referenced this issue Jul 1, 2021
@vemv vemv closed this as completed in fddd9ad Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant