Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle NoClassDefFoundError when determining class type #186

Closed
wants to merge 2 commits into from
Closed

Handle NoClassDefFoundError when determining class type #186

wants to merge 2 commits into from

Commits on Jan 22, 2017

  1. Handle NoClassDefFoundError when determining class type 

    When `resolve-missing` gets a number of candidate classes, it will load them to
determine the type (Clojure type/record vs regular Java class). However a class
on the classpath may be compiled with dependencies that are not currently
present, causing the loading to fail.

This would cause the whole operation to fail, instead this change handles the
exception, takes it as a sign that it's a regular Java class, and continues.

For example, I do a `resolve-missing` on the symbol URL, this yields two
candidates: `java.net.URL`, and
`com.gargoylesoftware.htmlunit.javascript.host.URL`. The latter depends on
`org.w3c.dom.ElementTraversal`, which is not currently present, causing a
`NoClassDefFoundError`.
    @plexus
    plexus committed Jan 22, 2017
    Configuration menu
    Copy the full SHA
    d83873f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into handle-no-class-def-found

    @expez
    expez committed Jan 22, 2017
    Configuration menu
    Copy the full SHA
    d333f19 View commit details
    Browse the repository at this point in the history