Improve shadow cljs support #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes project-root detection for shadow-cljs projects that don't also have a project.clj or deps.edn file
… as strings
shadow-cljs supports string namespaces for requiring NPM dependencies,
eg:
(:require [reagent.core :as r]
["react-virtualized/dist/commonjs/List" :refer [List]])
By comparing all namespaces as strings, we fix a ClassCast crash trying
to compare such a string to a normal symbol.
|
Thanks @dhleong! Much appreciated! |
|
I tried doing I see that the last snapshot was deployed in late July. Is ^ why, @bbatsov? |
|
I don't remember the failure. There hasn't been new shapshot releases recently because there wasn't a lot of action on the project (and I was busy with other work). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
lein do clean, test)./build.sh install-- takes a long time)Thanks!