Understanding decision merge

[stuarthalloway]

The merge performed by a decision function is not a Clojure map merge, e.g. merging these two maps

{:request {:params {:a "1"}}}
{:request {:params {:b "2"}}}

will leave :params with both :a and :b keys. The current behavior is exactly what I wanted, but I had to test it to understand. I think docs need a different word than merge -- having now checked the impl I see you call it merge-map-element. Maybe there is a standard name from some other FP language...

[ordnungswidrig]

This is one of the points that must be worked out in more detail before I want to release a 1.0. The current behavior is often the desired one, but you cannot remove an existing key. In any case the behavior and the motivation behind it must be documented.

[malcolmsparks]

My suggestion is to rename it 'combine'. Since that name doesn't clash with
anything in clojure.core it will avoid confusion with clojure.core/merge
and clojure.core/merge-with

On 10 October 2012 08:20, Philipp Meier notifications@github.com wrote:

This is one of the points that must be worked out in more detail before I
want to release a 1.0. The current behavior is often the desired one, but
you cannot remove an existing key. In any case the behavior and the
motivation behind it must be documented.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/11#issuecomment-9292298.

[ordnungswidrig]

Renaming to 'combine' sounds reasonable.