Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider exposing API via babashka pod #555

Closed
borkdude opened this issue Sep 15, 2021 · 4 comments · Fixed by clj-kondo/clj-kondo#1499 or #674
Closed

Consider exposing API via babashka pod #555

borkdude opened this issue Sep 15, 2021 · 4 comments · Fixed by clj-kondo/clj-kondo#1499 or #674
Labels
API Related to API / CLI enhancement New feature or request
Projects
clojure-lsp

Comments

@borkdude
Copy link
Contributor

borkdude commented Sep 15, 2021 •
edited

When doing so, we can call the API directly from babashka scripts.

More info on how clj-kondo does this: https://github.com/clj-kondo/clj-kondo/blob/master/src/pod/borkdude/clj_kondo.clj
@borkdude borkdude added API Related to API / CLI bug Something isn't working labels Sep 15, 2021
@borkdude
Copy link
Contributor Author

This is not the bug, please remove the bug label.

@ericdallo ericdallo added enhancement New feature or request and removed bug Something isn't working labels Sep 15, 2021
@ericdallo
Copy link
Member

Oh, interesting, I will take a look!

@ericdallo ericdallo added this to Low priority in clojure-lsp via automation Sep 15, 2021
@borkdude
Copy link
Contributor Author

@ericdallo Here is an example of how to run the clj-kondo pod:

https://github.com/babashka/pod-registry/blob/master/examples/clj-kondo.clj

@ericdallo ericdallo mentioned this issue Dec 15, 2021
Merged
3 tasks
clojure-lsp automation moved this from Low priority to Next release Dec 15, 2021
borkdude added a commit to clj-kondo/clj-kondo that referenced this issue Dec 15, 2021
@ericdallo @borkdude
[clojure-lsp/clojure-lsp#555] Improve potemkin analysis (#1499)
3c9169b 
Co-authored-by: Michiel Borkent <michielborkent@gmail.com>
@ericdallo
Copy link
Member

I think I wrongly mentioned this issue on the PR, sorry

@ericdallo ericdallo reopened this Dec 17, 2021
clojure-lsp automation moved this from Next release to In progress Dec 17, 2021
@ericdallo ericdallo moved this from In progress to Low priority in clojure-lsp Dec 17, 2021
@ericdallo ericdallo moved this from Low priority to In progress in clojure-lsp Dec 18, 2021
@ericdallo ericdallo mentioned this issue Dec 18, 2021
Merged
clojure-lsp automation moved this from In progress to Next release Dec 18, 2021
@ericdallo ericdallo moved this from Next release to Done in clojure-lsp Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Related to API / CLI enhancement New feature or request
Projects
clojure-lsp
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve potemkin analysis ericdallo/clj-kondo
Add babashka pod clojure-lsp/clojure-lsp
2 participants
@borkdude @ericdallo