Use parser/safe-zloc-of-string #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts all usages of `parser/zloc-of-string` to `parser/safe-zloc-of-string`. Instead of letting exceptions short-circuit, we short-circuit on nils. This keeps stack traces out of the logs. This patch also improves the performance of call hierarchies by parsing less. There's more performance work that can be done here. See comments in call_hierarchy.clj.
mainej
commented
Jun 30, 2022
ericdallo
reviewed
Jun 30, 2022
Comment on lines
30
to
31
| ;; TODO: tests pass if this branch is removed. Why can't we use | ||
| ;; the else branch for project files? |
There was a problem hiding this comment.
Good question, I can't recall why I added that at the time, but if we can always get the namespace reliable and fallback for filenames when not available, seems already good enough, so the else branch makes sense.
Also, parsing the loc just to find the namespace name sounds too much
ericdallo
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts all usages of
parser/zloc-of-stringtoparser/safe-zloc-of-string. Instead of letting exceptions short-circuit, we short-circuit on nils. This keeps stack traces out of the logs.This patch also improves the performance of call hierarchies by parsing less. This was just an opportunistic refactoring—while looking at the parsing done in call-hierarchy I noticed were doing it a lot more frequently than necessary. There's more performance work that can be done here. See comments in call_hierarchy.clj.
I created an issue to discuss the problem I am trying to solve or an open issue already exists.I updated documentation if applicable (docsfolder)