Fix Calva's escaped URIs rename issue #1389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
can you pelase consider patch for restoring renaming functionality on VS Code/Calva on MS-Widnows. It fixes #1388
The bug was inroduced with #1327, which added special handling for escaped URIs coming from Calva (which unexpectedly even encodes the colon in a drive schema). It introduced a lot of
(normalize-doc-uri)
inside the request handlers, but it is not obvious whether the rename handler was missed by mistake. Question: what qualifies for handled by(normalize-doc-uri)
in the server? It is not obvious to me.This patch introduces the missing form for the rename handler. A test has also been extended to test the rename function. The escape uri fn has been updated to introduced calva's escaping behavior.
thanks
docs
folder)