Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Calva's escaped URIs rename issue #1389

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

ikappaki
Copy link
Contributor

@ikappaki ikappaki commented Nov 24, 2022

Hi,

can you pelase consider patch for restoring renaming functionality on VS Code/Calva on MS-Widnows. It fixes #1388

The bug was inroduced with #1327, which added special handling for escaped URIs coming from Calva (which unexpectedly even encodes the colon in a drive schema). It introduced a lot of (normalize-doc-uri) inside the request handlers, but it is not obvious whether the rename handler was missed by mistake. Question: what qualifies for handled by (normalize-doc-uri) in the server? It is not obvious to me.

This patch introduces the missing form for the rename handler. A test has also been extended to test the rename function. The escape uri fn has been updated to introduced calva's escaping behavior.

thanks

  • I created an issue to discuss the problem I am trying to solve or an open issue already exists.
  • I added a new entry to CHANGELOG.md
  • I updated documentation if applicable (docs folder)

Copy link
Member

@ericdallo ericdallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks again!

@ericdallo ericdallo merged commit c968535 into clojure-lsp:master Nov 24, 2022
@mainej
Copy link
Collaborator

mainej commented Nov 29, 2022

Good catch—the rename handler was missed by mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2022.11.03-00.14.57 Does not allow renaming on windows
3 participants