Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix call to ns-groups when :filename-pattern in use #1825

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Fix call to ns-groups when :filename-pattern in use #1825

merged 2 commits into from
Jul 1, 2024

Conversation

SevereOverfl0w
Copy link
Contributor

@SevereOverfl0w SevereOverfl0w commented May 22, 2024 •
edited
Loading

  • I created an issue to discuss the problem I am trying to solve or an open issue already exists.
  • I added a new entry to CHANGELOG.md
  • I updated documentation if applicable (docs folder)

@SevereOverfl0w SevereOverfl0w force-pushed the dominic/fix-kondo-filename-pattern branch from c034f2b to e88bd58 Compare May 22, 2024 16:42
@SevereOverfl0w SevereOverfl0w force-pushed the dominic/fix-kondo-filename-pattern branch from e88bd58 to 452582d Compare May 22, 2024 18:41
@SevereOverfl0w
Copy link
Contributor Author

SevereOverfl0w commented May 23, 2024 •
edited
Loading

I don't understand what & why the macos integration test is timing out, is it known to be flaky? I've pushed up a commit using a dynamic var & memoization (as I saw elsewhere in the file) to see if it will speed up the build sufficient to get it through.

Nvm, just spotted that lots of the other PRs are failing with the same reason!

@SevereOverfl0w SevereOverfl0w force-pushed the dominic/fix-kondo-filename-pattern branch from 7b94439 to 452582d Compare May 25, 2024 10:22
ericdallo
ericdallo approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@ericdallo ericdallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ericdallo ericdallo merged commit 773b91f into clojure-lsp:master Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericdallo ericdallo ericdallo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SevereOverfl0w @ericdallo