Fix call to ns-groups when :filename-pattern in use #1825

SevereOverfl0w · 2024-05-22T16:41:49Z

I created an issue to discuss the problem I am trying to solve or an open issue already exists.
I added a new entry to CHANGELOG.md
I updated documentation if applicable (docs folder)

SevereOverfl0w · 2024-05-23T06:52:08Z

I don't understand what & why the macos integration test is timing out, is it known to be flaky? I've pushed up a commit using a dynamic var & memoization (as I saw elsewhere in the file) to see if it will speed up the build sufficient to get it through.

Nvm, just spotted that lots of the other PRs are failing with the same reason!

lib/src/clojure_lsp/feature/diagnostics.clj

SevereOverfl0w force-pushed the dominic/fix-kondo-filename-pattern branch from c034f2b to e88bd58 Compare May 22, 2024 16:42

Fix call to ns-groups when :filename-pattern in use

452582d

SevereOverfl0w force-pushed the dominic/fix-kondo-filename-pattern branch from e88bd58 to 452582d Compare May 22, 2024 18:41

ericdallo reviewed May 23, 2024

View reviewed changes

lib/src/clojure_lsp/feature/diagnostics.clj Outdated Show resolved Hide resolved

SevereOverfl0w force-pushed the dominic/fix-kondo-filename-pattern branch from 7b94439 to 452582d Compare May 25, 2024 10:22

SevereOverfl0w requested a review from ericdallo June 3, 2024 18:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix call to ns-groups when :filename-pattern in use #1825

Fix call to ns-groups when :filename-pattern in use #1825

SevereOverfl0w commented May 22, 2024 •

edited

SevereOverfl0w commented May 23, 2024 •

edited

Fix call to ns-groups when :filename-pattern in use #1825

Are you sure you want to change the base?

Fix call to ns-groups when :filename-pattern in use #1825

Conversation

SevereOverfl0w commented May 22, 2024 • edited

SevereOverfl0w commented May 23, 2024 • edited

SevereOverfl0w commented May 22, 2024 •

edited

SevereOverfl0w commented May 23, 2024 •

edited