update tp 1.5x #73
Closed
update tp 1.5x #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, generate-proxy for abstract classes produced incorrect bytecode, with a call to super's method (which obviously doesn't exist for abstract methods). Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
… specified class Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
Fixes CLJ-1485 Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not. Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Rich Hickey <richhickey@gmail.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
…aps* Signed-off-by: Rich Hickey <richhickey@gmail.com>
Signed-off-by: Rich Hickey <richhickey@gmail.com>
Moved old printer to clojure.spec/explain-printer. Added dynamic variable clojure.spec/*explain-out*. Set default *explain-out* to explain-printer. Changed explain-out to invoke *explain-out*. Changed repl to bind *explain-out* so it can be set!'ed. Signed-off-by: Rich Hickey <richhickey@gmail.com>
… strings Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
dir-fn will now work on namespace aliases in addition to canonical namespaces. Add test for same, compatible with direct linking, introduced in Clojure 1.8.0-alpha3. Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Stuart Halloway <stu@cognitect.com>
…hies into account in multi-spec Signed-off-by: Stuart Halloway <stu@cognitect.com>
Signed-off-by: Rich Hickey <richhickey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.