CLJS-3401: dedupe '+ and '_PLUS symbols with :optimize-constants (#203)

Co-authored-by: Michiel Borkent <michielborkent@gmail.com>
clojure · Apr 10, 2023 · 0ccd19f · 0ccd19f
1 parent 30171a3
commit 0ccd19f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/main/clojure/cljs/analyzer.cljc b/src/main/clojure/cljs/analyzer.cljc
@@ -513,14 +513,16 @@
                  (symbol? value)  "cst$sym$"
                  :else
                  (throw
-                   #?(:clj (Exception. (str "constant type " (type value) " not supported"))
-                      :cljs (js/Error. (str "constant type " (type value) " not supported")))))
+                  #?(:clj (Exception. (str "constant type " (type value) " not supported"))
+                     :cljs (js/Error. (str "constant type " (type value) " not supported")))))
         name   (if (keyword? value)
                  (subs (str value) 1)
                  (str value))
         name   (if (= "." name)
                  "_DOT_"
                  (-> name
+                     (string/replace "_" "__")
+                     (string/replace "$" "$$")
                      (string/replace "-" "_DASH_")
                      (munge)
                      (string/replace "." "$")

diff --git a/src/test/clojure/cljs/analyzer_tests.clj b/src/test/clojure/cljs/analyzer_tests.clj
@@ -1512,3 +1512,9 @@
                     (Foo. nil nil)))))
     (is (= 1 (count @ws)))
     (is (string/starts-with? (first @ws) "Wrong number of args (2) passed to Foo"))))
+
+(deftest test-cljs-3401
+  (is (not= (ana/gen-constant-id '_PLUS_)
+            (ana/gen-constant-id '+)))
+  (is (not= (ana/gen-constant-id 'foo.bar)
+            (ana/gen-constant-id 'foo$bar))))