get-in behaves incorrectly on values

Values which don't satisfy `ILookup` are handled incorrectly.
clojure · Jan 26, 2013 · e8d2022 · e8d2022
1 parent ad3ffec
commit e8d2022
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/src/cljs/cljs/core.cljs b/src/cljs/cljs/core.cljs
@@ -2737,10 +2737,12 @@ reduces them without incurring seq initialization"
             m m
             ks (seq ks)]
        (if ks
-         (let [m (get m (first ks) sentinel)]
-           (if (identical? sentinel m)
-             not-found
-             (recur sentinel m (next ks))))
+         (if (not (satisfies? ILookup m))
+           not-found
+           (let [m (get m (first ks) sentinel)]
+             (if (identical? sentinel m)
+               not-found
+               (recur sentinel m (next ks)))))
          m))))
 
 (defn assoc-in

diff --git a/test/cljs/cljs/core_test.cljs b/test/cljs/cljs/core_test.cljs
@@ -1797,5 +1797,10 @@
   (assert (= (assoc {} 154618822656 1 261993005056 1)
              {154618822656 1 261993005056 1}))
 
+  ;; CLJS-458
+
+  (assert (= (get-in {:a {:b 1}} [:a :b :c] :nothing-there)
+             :nothing-there))
+
   :ok
   )