CLJS-3373: Externs Inference issue with vars invoked from foreign libs #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix invoke inference to handle invokes on vars from foreign libs. If we have a :js-var we cannot know whether it is a function or property. Note this is different from the `:js-fn-var` case where a provided extern did disambiguate. In the case of `:js-var` we throw away the leading prefix since the types simply cannot be known. Add a test case based on the one provided by Timothy Pratley.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix invoke inference to handle invokes on vars from foreign libs. If
we have a :js-var we cannot know whether it is a function or property.
Note this is different from the
:js-fn-varcase where a providedextern did disambiguate.
In the case of
:js-varwe throw away the leading prefix since thetypes simply cannot be known.
Add a test case based on the one provided by Timothy Pratley.