Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional attr and text predicate constructors for data.zip.xml #2

Closed
wants to merge 1 commit into from

Conversation

calebmpeterson
Copy link

Added two attr predicates:

(attr-in? :the-attr #{"valid value 1" "valid value 2" "etc..."})
(attr-like? :the-attr #"[Aa] pattern.*)

And two symmetric text predicates:

(text-in? #{"valid value 1" "valid value 2" "etc..."})
(text-like? #"[Hh]ello .*")

Also updated the test suite to exercise each predicate constructor.

@seancorfield
Copy link
Member

Hi Caleb,

Thanx for your suggestion. Unfortunately the Clojure projects - core and contrib - cannot accept pull requests (and we can't turn that feature off in Github). You can submit enhancement requests (and bug reports) via JIRA - http://dev.clojure.org/jira/browse/DZIP

Since you're interested in contributing, could you complete and submit a Contributor's Agreement per http://clojure.org/contributing ? That would open up the Clojure development process to you and you could submit patches on JIRA tickets at that point and get more deeply involved with the evolution of Clojure and its libraries.

Regards,
Sean

@calebmpeterson
Copy link
Author

Sean,

Thank you for such a considerate reply and for pointing me in the right direction re: contributing to Clojure. I'll get the Contributor's Agreement filled out and mailed.

Regards,
Caleb

@seancorfield
Copy link
Member

Always good to have more contributors involved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants