Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port rtmbot to python3 and v2 of the slackclient #54

Merged
merged 7 commits into from
Jul 15, 2019
Merged

Port rtmbot to python3 and v2 of the slackclient #54

merged 7 commits into from
Jul 15, 2019

Commits on Jul 9, 2019

  1. Move to python3.

    @bombaywalla
    bombaywalla committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    a14c368 View commit details
    Browse the repository at this point in the history

  2. First pass at python3 rtmbot. Still WIP.

    @bombaywalla
    bombaywalla committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    3b8f1b2 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2019

  1. Add back the type attribute of the data. 

    That is removed from the payload by the v2 slack api.

Also improved the log message if an exception is caught.
    @bombaywalla
    bombaywalla committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    dfb2fe4 View commit details
    Browse the repository at this point in the history

  2. Removed DAEMON capability. 

    No longer needed since handled by systemd.
    @bombaywalla
    bombaywalla committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    f4caa2f View commit details
    Browse the repository at this point in the history

  3. No need to log the directory containing rtmbot.

    @bombaywalla
    bombaywalla committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    061b1ac View commit details
    Browse the repository at this point in the history

  4. Removed the now-unnecessary import of os. 

    Updated the comment to correctly reflect what this does.
    @bombaywalla
    bombaywalla committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    493bc17 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2019

  1. Ported rtmbot to python3 and v2 of slackclient.

    @bombaywalla
    bombaywalla committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    4cc22fd View commit details
    Browse the repository at this point in the history