Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render emoji to hiccup #74

Merged
merged 2 commits into from Sep 20, 2019
Merged

Render emoji to hiccup #74

merged 2 commits into from Sep 20, 2019

Conversation

dawranliou
Copy link
Collaborator

@dawranliou dawranliou commented Sep 19, 2019 •
edited

Problem: #71

Solution:

  • Add emojis.json to resource
  • Build the text->emoji map
  • Turn text to emoji in clojurians-log.slack-messages/message->hiccup

Sreenshot:
image

@dawranliou
Render emoji to hiccup
616384e 
* Add emojis.json to resource
* Build the `text->emoji` map
* Turn text to emoji in `clojurians-log.slack-messages/message->hiccup`
@plexus plexus merged commit 36b04b2 into master Sep 20, 2019
@plexus plexus deleted the issue-71-render-emoji branch September 20, 2019 13:52
@plexus
Copy link
Member

plexus commented Sep 20, 2019

Awesome!

@plexus
Copy link
Member

plexus commented Sep 20, 2019

And it's live!

@dawranliou
Copy link
Collaborator Author

Great! That's very fast. Thanks!

@dawranliou dawranliou mentioned this pull request Sep 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plexus plexus Awaiting requested review from plexus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dawranliou @plexus