Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected mispelling of :pedantic? in project.clj #134

Merged
merged 1 commit into from Mar 9, 2017

Conversation

Rovanion
Copy link
Contributor

@Rovanion Rovanion commented Mar 6, 2017

I simply noticed that you had misspelt a key in your project.clj, so I corrected it.

@michaelklishin
Copy link
Member

I don't think it's a typo, not according to lein-pedantic's README. That project is now deprecated but that's a separate discussion.

@Rovanion
Copy link
Contributor Author

Rovanion commented Mar 9, 2017

It's been deprecated by the features now included in Leiningen I'd assume, where one of these is triggered by the :pedantic?, the docs for the key reads:

;; What to do in the case of version issues. Defaults to :ranges, which
;; warns when version ranges are present anywhere in the dependency tree,
;; but can be set to true to warn for both ranges and overrides, or :abort
;; to exit in the case of ranges or overrides.

If this is what you want, then I think the patch still applies.

@michaelklishin
Copy link
Member

Consider linking to the document you are quoting.

@michaelklishin michaelklishin reopened this Mar 9, 2017
@michaelklishin michaelklishin merged commit 1f7ed4f into clojurewerkz:master Mar 9, 2017
@Rovanion
Copy link
Contributor Author

Rovanion commented Mar 9, 2017

Leiningen seems to be lacking in the documentation department, but I was quoting the sample project file they've got:

https://github.com/technomancy/leiningen/blob/master/sample.project.clj#L77

@michaelklishin
Copy link
Member

Yes, I found it using GitHub search (and the comments suggested it was that file), thanks.

@Rovanion
Copy link
Contributor Author

Rovanion commented Mar 9, 2017

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants