Upsert documents with parent.

[r0man]

Hello,

I would like to upsert documents that have a parent. Right now
the upsert fn does not have any options to pass the parent. If
there's a interest I could send a PR for the upsert fn that
adds optional arguments in a similar way as the create fn. I
thought about something like this:

(defn upsert
  "Updates or creates a document using provided data"
  ([^Client conn index mapping-type ^String id ^Map doc & args]
     (let [{:keys [parent]} (ar/->opts args)
           req (cnv/->upsert-request index mapping-type id doc)
           req (if parent (.parent req parent) req)
           res (es/update conn req)]
       (cnv/update-response->map (.actionGet res)))))

Roman

[michaelklishin]

@r0man can you link to the relevant ES documentation page? We can modify the existing API but I'd like to understand the feature better.

[r0man]

hey @michaelklishin,

When you create a document with Elastisch you can specify
the :parent of a document. This option is not available in the
upsert fn, which can also create a document. We used to do this
with HTTP PUT requests, but switching over to Elastisch now.

I think the docs you want is this one:

http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/docs-update.html

In the Java API you can do this with the .parent method of the UpdateReqeust

https://github.com/elasticsearch/elasticsearch/blob/master/src/main/java/org/elasticsearch/action/update/UpdateRequest.java#L176

Roman

[michaelklishin]

@r0man please try master.