Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow explicit connection passing #80

Closed
jasongilman opened this issue Apr 16, 2014 · 7 comments
Closed

Allow explicit connection passing #80

jasongilman opened this issue Apr 16, 2014 · 7 comments
Assignees
Labels

Comments

@jasongilman
Copy link

It looks like elastisch only allows use of a global connection to elastic. This breaks cases where an application would want to use multiple connections to elastic. The API functions should take an optional connection in cases where a global connection is not appropriate.

@michaelklishin
Copy link
Member

One problem with this is that we already have 2 clients and there are many features in ES. So adding alternative API namespaces will quadruple the API, in some sense (there will be 4 variants of the same function).

So I'm inclined to make client a mandatory argument for 2.0.

@michaelklishin
Copy link
Member

Working on this today and tomorrow. Stay tuned.

@michaelklishin
Copy link
Member

It turns out to be much more time consuming (mostly updating the tests) but I'm making progress.

@michaelklishin
Copy link
Member

REST client is converted, native is in progress.

michaelklishin added a commit that referenced this issue Apr 25, 2014
@michaelklishin
Copy link
Member

In master. Now we need to update all the code examples in the docs :finnadie: 🎌.

michaelklishin added a commit to clojurewerkz/elastisch.docs that referenced this issue Apr 25, 2014
@michaelklishin
Copy link
Member

The docs are updated.

@jasongilman
Copy link
Author

That's awesome. I didn't expect such a fundamental change to be made so quickly or without pushback. This is going to make the library a better fit for many different use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants