Skip to content

Allow explicit connection passing #80

Closed
jasongilman opened this Issue Apr 16, 2014 · 7 comments

2 participants

@jasongilman

It looks like elastisch only allows use of a global connection to elastic. This breaks cases where an application would want to use multiple connections to elastic. The API functions should take an optional connection in cases where a global connection is not appropriate.

@michaelklishin
ClojureWerkz member

One problem with this is that we already have 2 clients and there are many features in ES. So adding alternative API namespaces will quadruple the API, in some sense (there will be 4 variants of the same function).

So I'm inclined to make client a mandatory argument for 2.0.

@michaelklishin michaelklishin self-assigned this Apr 19, 2014
@michaelklishin
ClojureWerkz member

Working on this today and tomorrow. Stay tuned.

@michaelklishin
ClojureWerkz member

It turns out to be much more time consuming (mostly updating the tests) but I'm making progress.

@michaelklishin michaelklishin referenced this issue in michaelklishin/monger Apr 22, 2014
Closed

Make DB a mandatory explicit argument #76

@michaelklishin michaelklishin added a commit that referenced this issue Apr 25, 2014
@michaelklishin michaelklishin Make clojurewerkz.elastisch.native functions accept connection (clien…
…t) as explicit first argument

References #80.
1bb3f9c
@michaelklishin
ClojureWerkz member

REST client is converted, native is in progress.

@michaelklishin michaelklishin added a commit that referenced this issue Apr 25, 2014
@michaelklishin michaelklishin Update reference docs
References #80.
3e1ef93
@michaelklishin
ClojureWerkz member

In master. Now we need to update all the code examples in the docs :finnadie: 🎌.

@michaelklishin michaelklishin added a commit to clojurewerkz/elastisch.docs that referenced this issue Apr 25, 2014
@michaelklishin michaelklishin Update Getting Started guide for 2.0 09f96b4
@michaelklishin
ClojureWerkz member

The docs are updated.

@jasongilman

That's awesome. I didn't expect such a fundamental change to be made so quickly or without pushback. This is going to make the library a better fit for many different use cases.

@michaelklishin michaelklishin referenced this issue in clojurewerkz/cassaforte May 14, 2014
Closed

Explicit connection/session argument #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.