-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow explicit connection passing #80
Comments
One problem with this is that we already have 2 clients and there are many features in ES. So adding alternative API namespaces will quadruple the API, in some sense (there will be 4 variants of the same function). So I'm inclined to make client a mandatory argument for 2.0. |
Working on this today and tomorrow. Stay tuned. |
It turns out to be much more time consuming (mostly updating the tests) but I'm making progress. |
…t) as explicit first argument References #80.
REST client is converted, native is in progress. |
In master. Now we need to update all the code examples in the docs |
The docs are updated. |
That's awesome. I didn't expect such a fundamental change to be made so quickly or without pushback. This is going to make the library a better fit for many different use cases. |
It looks like elastisch only allows use of a global connection to elastic. This breaks cases where an application would want to use multiple connections to elastic. The API functions should take an optional connection in cases where a global connection is not appropriate.
The text was updated successfully, but these errors were encountered: