terms query missing?

[martinklepsch]

Maybe I'm mistaken but I think the terms query is missing. Would you consider a patch adding it?

[michaelklishin]

Missing from elastisch.query? Definitely submit a pull request, I believe this query type is fairly recent.

[michaelklishin]

@mklappstuhl are you going to contribute this? If not, can you at least tell us where the terms query is missing?

[martinklepsch]

Going to contribute! I've been wrangling with editors (going from vim to
emacs) last couple of days but I'll take a look tomorrow or over the
weekend :)

On Wednesday, July 16, 2014, Michael Klishin notifications@github.com
wrote:

@mklappstuhl https://github.com/mklappstuhl are you going to contribute
this? If not, can you at least tell us where the terms query is missing?

—
Reply to this email directly or view it on GitHub
#96 (comment)
.

—
Martin
http://martinklepsch.org http://martinklepsch.org?ref=email

[michaelklishin]

@mklappstuhl hey, we do accept contributions from Vim users ;)

[martinklepsch]

Haha, yeah. Just gave emacs another concentrated try and that made my
productivity with everything else tank totally :D

On Wednesday, July 16, 2014, Michael Klishin notifications@github.com
wrote:

@mklappstuhl https://github.com/mklappstuhl hey, we do accept
contributions from Vim users ;)

—
Reply to this email directly or view it on GitHub
#96 (comment)
.

—
Martin
http://martinklepsch.org http://martinklepsch.org?ref=email

[martinklepsch]

@michaelklishin as it seems the clojurewerkz.elastisch.query/term function automagically becomes a terms query when you supply a collection:

(defn term
  "Term Query"
  [key values & args]
  (merge { (if (coll? values) :terms :term) (hash-map key values) }
         (ar/->opts args)))

I just put together a map on my own when I needed this unknowing that this would work. Maybe it'd be useful to add an alias so that it shows up in the API documentation?

[michaelklishin]

@mklappstuhl go ahead. A separate function in general should be fine (we can't change term immediately for backwards compatibility).

[martinklepsch]

I'm not sure. The existing term query properly supports terms queries as
well.
Duplicating that code doesn't sound like the best idea that's why I
suggested aliasing. Therefore no changes in functionality would be made,
everything would stay compatible.

[michaelklishin]

Fine, just define a function that will call term internally :)

[michaelklishin]

Fixed by #104. Thanks @mklappstuhl!