Elasticsearch 5 support #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error from Elasticsearch 5 without this is: "Content type detection for rest requests is deprecated. Specify the content type using the [Content-Type] header." Per clojurewerkz#257
|
FYI, Travis CI failure does not indicate test failures or uncaught exceptions - might be a Travis config vs desired test run config mismatch. |
michaelklishin
approved these changes
May 11, 2018
|
Thank you! |
|
Many thanks Brian. I was looking at adding content-type headers myself. |
|
When the docs are updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly fixes the content-type header so that Elasticsearch 5 does not complain.
Related (high-level) issue: #245
I'm including a cherry-picked change from Han Tuzun for delete-by-query which is not backwards-compatible. Please advise on that; could delay that easily.