Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safetensors dependency #87

Closed
oscarnevarezleal opened this issue Dec 26, 2022 · 3 comments
Closed

safetensors dependency #87

oscarnevarezleal opened this issue Dec 26, 2022 · 3 comments

Comments

@oscarnevarezleal
Copy link
Contributor

I believe #84 introduced a safetensors dependency but it's not specified in requirements.txt

@hafriedlander
Copy link
Collaborator

hafriedlander commented Dec 27, 2022

It's not supposed to be required, but it is currently because train_lora_dreambooth calls save_safeloras indiscriminately. I'll add a PR soon.

My intent was that safetensors will be required to save safetensors, but not to load them (there's a pure python version), and that pytorch pickles would remain an option.

(I'd personally prefer if safetensors became the default, but that's up to @cloneofsimo and the community generally).

@hafriedlander
Copy link
Collaborator

#101 should fix this

@hafriedlander
Copy link
Collaborator

This should be fixed now #101 is merged @oscarnevarezleal - feel free to reopen if something still breaks without safetensors installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants