Merge pull request #23 from cloocher/update_rubocop

Update rubocop

.travis.yml

@@ -1,9 +1,5 @@
 language: ruby
 rvm:
-  - 2.0.0
-  - 2.2.3
-  - 2.3.0
-  - 2.4.5
   - 2.5.1
   - 2.6.3
 env:

CHANGELOG.md

@@ -7,6 +7,7 @@ All changes to the XmlHasher gem are documented here. Releases follow semantic v
 - Resolve gem build warnings .
 - Run tests on CI
 - Little refactoring for Node hash builder.
+- Use new ruby style guide and `rubocop` gem.
 
 ## [1.0.5] - 2019-06-16
 

lib/xmlhasher/version.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
 module XmlHasher
-  # rubocop:disable Style/RedundantFreeze, Lint/UnneededCopDisableDirective
-  # if frozen_string_literal is not supported
-  VERSION = '1.0.5'.freeze
-  # rubocop:enable Style/RedundantFreeze, Lint/UnneededCopDisableDirective
+  VERSION = '1.0.5'
 end

test/xmlhasher/parser_test.rb

@@ -4,16 +4,14 @@
 
 class XmlhasherTest < Test::Unit::TestCase
   def test_string_parsing_no_tranformation
-    # rubocop:disable Style/HashSyntax, Lint/UnneededCopDisableDirective
-    # because ruby 2.0 does not support new hash syntax
     hash = {
       InstitutionDetail: {
         address: {
-          :'ns2:address1' => '100 Main Street',
-          :'ns2:city' => 'Anytown',
-          :'ns2:country' => 'USA',
-          :'ns2:postalCode' => '94043',
-          :'ns2:state' => 'CA'
+          'ns2:address1': '100 Main Street',
+          'ns2:city': 'Anytown',
+          'ns2:country': 'USA',
+          'ns2:postalCode': '94043',
+          'ns2:state': 'CA'
         },
         currencyCode: 'ANG',
         emailAddress: 'CustomerCentralBank@intuit.com',
@@ -51,10 +49,10 @@ def test_string_parsing_no_tranformation
         },
         phoneNumber: '123-456-7890',
         xmlns: 'http://schema.intuit.com/platform/fdatafeed/account/v1',
-        :'xmlns:ns2' => 'http://schema.intuit.com/platform/fdatafeed/common/v1'
+        'xmlns:ns2': 'http://schema.intuit.com/platform/fdatafeed/common/v1'
       }
     }
-    # rubocop:enable Style/HashSyntax, Lint/UnneededCopDisableDirective
+    # rubocop:enable
     result = XmlHasher::Parser.new.parse(fixture('institution.xml').read)
     assert_equal hash, result
   end