Feature/cl 8956 add new partner api methods #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good to me. Can you also add examples please (check example folder)? |
|
You can check such URL https://github.com/close-dev-team/partner-sdk-php/blob/main/examples/text%20message/sendToAllChatsForEvent.md for example |
|
Shouldn't we also add the endpoints for the Message: Cards (found in here)? With this we can add carousels and look for them, but we can't send images to them. There 4 methods that allows us to do that. |
dpenasclose
reviewed
Jun 29, 2023
examples/carousel/createCarousel.md
Outdated
| @@ -0,0 +1,30 @@ | |||
| # Sending a message to all users in all chats for one event. | |||
| Do you want to send a message to all users going to a specific event? Then you can use the sendToAllChatsForEvent() operation. | |||
There was a problem hiding this comment.
Maybe this text should change? It is about creating the carousel, not sending a message. The one below (the lookup one) should also change.
added 2 commits
July 3, 2023 16:02
anton-close
approved these changes
Jul 5, 2023
|
after we merge this one, we have to a new release, so it's available in packagist if you download the package |
chrisangelocloseapp
deleted the
feature/CL-8956-add-new-partner-api-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.