Add handling for non-ASCII characters in error messages #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
movermeyer
changed the title
movermeyer
force-pushed
the
non_ascii_support_for_error_messages
branch
from
68f58b8
to
efbea4c
Compare
movermeyer
changed the title
movermeyer
force-pushed
the
non_ascii_support_for_error_messages
branch
from
efbea4c
to
c19fc99
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the unexpected character was not ASCII, the error message formatting was misbehaving.
For Python 3, we'll print the character as always (now accepting Unicode characters)
For Python 2, we will simply not include the character in the error message if it's not an ASCII character.
Fixes #84