Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTime should always return a datetime.datetime #45

Closed
caseywebdev opened this issue Mar 12, 2019 · 3 comments · Fixed by #66
Closed

DateTime should always return a datetime.datetime #45

caseywebdev opened this issue Mar 12, 2019 · 3 comments · Fixed by #66

Comments

@caseywebdev
Copy link
Contributor

Currently, DateTime will return a datetime.date for ISO8601 dates like 2000-01-01 and a datetime.datetime for ISO8601 datetimes like 2000-01-01T00:00:00Z. This is not expected behavior. Date should return a date, DateTime should return a datetime, and something like Union(Date, Datetime) should do what the current DateTime does.
@wojcikstefan
Copy link
Member

I believe this is still an issue.

@wojcikstefan wojcikstefan reopened this Jan 24, 2021
@mbdaryanto
Copy link
Contributor

Can I try to fix this issue?

@AlecRosenbaum
Copy link
Contributor

Sure, go for it.

@AlecRosenbaum AlecRosenbaum mentioned this issue Sep 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make DateTime validator always return a datetime closeio/cleancat
4 participants
@caseywebdev @wojcikstefan @AlecRosenbaum @mbdaryanto