This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
Do not depend on flask-views package #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpessas
force-pushed
the
drop-flask-views-dependency
branch
8 times, most recently
from
a232b96
to
d77c48c
Compare
The package only uses [1] which just sets ``self.args`` and ``self.kwargs`` that are not used anywhere. [1]: https://github.com/brocaar/flask-views/blob/master/flask_views/base.py#L5-L36
mpessas
force-pushed
the
drop-flask-views-dependency
branch
from
d77c48c
to
760218c
Compare
tsx
approved these changes
Aug 23, 2019
.circleci/config.yml
Outdated
| - run: | ||
| name: Lint | ||
| command: pipenv run flake8 | ||
| command: pip install --user -r $REQUIREMENTS_FILE nose flake8 |
There was a problem hiding this comment.
You probably did not intend to replace running (pipenv run) flake8 with installing it? It's already installed as part of requirements.txt.
mpessas
force-pushed
the
drop-flask-views-dependency
branch
from
2ac34ef
to
a297af8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package only uses 1 which just sets
self.argsandself.kwargsthatare not used anywhere.