This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
Document a bunch of Resource methods #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduces two helper methods (`update_objects` and `update_object`) that can be overridden in subclasses - Makes sure `view_method` is propagated to subresources - Fixes an issue where `has_change_permission` is called after the object is updated in bulk updates - Fixes an issue where `obj.save()` is unnecessarily called after `update_object()` (which already saves) in bulk updates
| @@ -214,18 +265,25 @@ def serialize_field(self, obj, **kwargs): | |||
| return self.serialize(obj, **kwargs) | |||
|
|
|||
| def _subresource(self, obj): | |||
| """Selects and creates an appropriate sub-resource class for delegation or return None if there isn't one""" | |||
| """ | |||
| Selects and creates an appropriate sub-resource class for delegation | |||
There was a problem hiding this comment.
"Select and create" (otherwise "or return None" won't grammar)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched off of @thomasst 's tweaks from #89, should be diff'd and merged after that one is merged.
Includes minor style/logic tweaks on top docstrings/comments.