Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis-py 3 #11

Merged
merged 2 commits into from
Mar 2, 2021
Merged

redis-py 3 #11

merged 2 commits into from
Mar 2, 2021

Conversation

jpmelos
Copy link
Contributor

@jpmelos jpmelos commented Mar 2, 2021

Make redis-hashring support redis-py 3 and drop support for redis-py 2. Dropped support for Python 2 (as in not running tests on that anymore). Also Black, pytestify tests, make tests run in Python 3.6, 3.7, 3.8, make a few other changes to setup.py. Black was applied in a separate commit to make the PR easier to review.

@jpmelos jpmelos requested a review from jkemp101 March 2, 2021 17:05
@jpmelos jpmelos self-assigned this Mar 2, 2021
@jpmelos jpmelos changed the title Redis py 3 joao redis-py 3 Mar 2, 2021
@jpmelos jpmelos requested review from thomasst and removed request for jkemp101 March 2, 2021 17:14
Copy link
Member

@thomasst thomasst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming 3.5 still works but we're dropping it since it's no longer a supported version?

@jpmelos
Copy link
Contributor Author

jpmelos commented Mar 2, 2021

Correct.

@jpmelos jpmelos merged commit db3c0e3 into master Mar 2, 2021
@jpmelos jpmelos deleted the redis-py-3-joao branch March 2, 2021 17:57
@jpmelos jpmelos mentioned this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants