Fix installation requirements #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both installing from pip and cloning the repository and running `setup.py install` both fail as a result of missing requirements. This patch adds those requirements listed in requirements.txt to setup.py. Closes #6
|
Thanks for the PR! I'm not sure if we should specify exact version numbers in |
Remove explicit versioning from install_requires directive
|
Thanks for the quick response, I've updated the PR to remove explicit versioning. Let me know if you'd prefer these two commits be squashed. |
thomasst
added a commit
that referenced
this pull request
Jan 20, 2016
Fix installation requirements
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both installing from pip and cloning the repository and running
setup.py installboth fail as a result of missing requirements. Thispatch adds those requirements listed in requirements.txt to setup.py.
Tested with
python setup.py installas well aspip install -e ~/tasktigerCloses #6