Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid ignore pattern for underscore files #233

Conversation

baptisteArno
Copy link
Contributor

Was discussed here: #107 (comment)

Closes #232

@netlify
Copy link

netlify bot commented Nov 28, 2022

Deploy Preview for docusaurus-openapi ready!

Name Link
🔨 Latest commit 49c1d15
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-openapi/deploys/6384e2a235a78200090ae810
😎 Deploy Preview https://deploy-preview-233--docusaurus-openapi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bourdakos1
Copy link
Member

bourdakos1 commented Nov 28, 2022

Is GlobExcludeDefault used anywhere else? Can we just add **/_category_.{json,yaml,yml} to it so we don’t need to do the filtering or pushing of the _spec_ files?

@baptisteArno
Copy link
Contributor Author

True! That should work just fine 👌

@bourdakos1
Copy link
Member

Hmm it looks like the demo isn’t picking up the _spec_ 🤔

I didn’t realize the default glob is coming directly from Docusaurus, so maybe they changed their glob in a newer version?

@baptisteArno
Copy link
Contributor Author

That's a mystery for me, I checked the file history that contains the GlobIgnore pattern, it has never changed 🤔 I'll investigate and let you know

@baptisteArno
Copy link
Contributor Author

It's this pattern "**/_*/**" that excludes _spec_.* files.

Let's just not rely on GlobExcludeDefault for this source fetching. It's useless.

@baptisteArno baptisteArno force-pushed the fix/duplicate-spec-underscore-file branch from cefef96 to de90201 Compare November 28, 2022 16:28
@baptisteArno baptisteArno force-pushed the fix/duplicate-spec-underscore-file branch from de90201 to 49c1d15 Compare November 28, 2022 16:32
@bourdakos1 bourdakos1 merged commit 121a75e into cloud-annotations:main Nov 28, 2022
@baptisteArno baptisteArno deleted the fix/duplicate-spec-underscore-file branch November 28, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paths are rendered twice when converting my schema file to _spec_.json
2 participants