Implement numjobs as a list to loop through for fio-d #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also included a number of other fixes/enhancements for fio-d.
12 tasks
jtaleric
reviewed
Jul 10, 2019
There was a problem hiding this comment.
Does this remove a lot of the work @aakarshg did to ensure we could index similar to how @bengland2 and AlexC store their results?
|
We'll need to check that. I don't have much knowledge of the indexing to
know if this change disrupts things.
…On Wed, Jul 10, 2019, 6:27 AM Joe (rook) ***@***.***> wrote:
***@***.**** commented on this pull request.
Does this remove a lot of the work @aakarshg <https://github.com/aakarshg>
did to ensure we could index similar to how @bengland2
<https://github.com/bengland2> and AlexC store their results?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#147>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACRJZLXA3CUHXZ5NQD4ML33P6W2PZANCNFSM4H7JC4CA>
.
|
|
/hold @dustinblack @jtaleric will text the indexing part locally. |
dustinblack
added
the
hold
|
Pending updates to fio-d to work with SNAFU for proper indexing. Will revisit this enhancement after that. |
|
Closing as outdated since the primary change here was implemented in PR #154, though I will bring back a couple of the smaller changes from this in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also included a number of other fixes/enhancements for fio-d. Addresses items in issue #141