[BUG] router v2 test fails if oc version is above 1.19

[dry923]

When running the routerv2 test with oc versions above 1.19 the following error is thrown from this line of code.

Common.sh file:

log "Adding workload.py to the client pod"
oc set volumes -n http-scale-client deploy/http-scale-client --type=configmap --mount-path=/workload --configmap-name=workload --add

Error:

Error: unknown flag: --type
See 'kubectl set --help' for usage.

OC version that failed:

# ./oc_1_20 version
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.0", GitCommit:"af46c47ce925f4c4ad5cc8d1fca46c7b77d13b38", GitTreeState:"clean", BuildDate:"2020-12-08T17:59:43Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.0+2f3101c", GitCommit:"2f3101cb663d0cb102ccb9730b63753604f6d29b", GitTreeState:"clean", BuildDate:"2021-02-26T13:55:24Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}

OC version that worked:

# oc version 
Client Version: 4.6.0-202103060018.p0-aaa9ca3
Server Version: 4.6.21
Kubernetes Version: v1.19.0+2f3101c

[rsevilla87]

Hey @dry923, are you sure you're using oc rather than kubectl?, I've verified that the oc set volumes subcommand is available in latest oc binary available.

rsevilla@wonderland /tmp $ oc version
Client Version: 4.6.7
Server Version: 4.8.0-0.nightly-2021-04-09-222447
Kubernetes Version: v1.21.0-rc.0+f381840
rsevilla@wonderland /tmp $ ./oc set -h
Configure application resources

 These commands help you make changes to existing application resources.

Usage:
  oc set COMMAND [flags]

Manage workloads:
  deployment-hook Update a deployment hook on a deployment config
  env             Update environment variables on a pod template
  image           Update image of a pod template
  probe           Update a probe on a pod template
  resources       Update resource requests/limits on objects with pod templates
  selector        Set the selector on a resource
  serviceaccount  Update ServiceAccount of a resource
  volumes         Update volumes on a pod template

Manage secrets and config:
  data            Update the data within a config map or secret
  build-secret    Update a build secret on a build config

Manage application flows:
  build-hook      Update a build hook on a build config
  image-lookup    Change how images are resolved when deploying applications
  triggers        Update the triggers on one or more objects

Manage load balancing:
  route-backends  Update the backends for a route

Manage authorization policy:
  subject         Update User, Group or ServiceAccount in a RoleBinding/ClusterRoleBinding

Use "oc set <command> --help" for more information about a given command.
Use "oc options" for a list of global command-line options (applies to all commands).

[dry923]

@rsevilla87 So version 1.20 of oc does not have set volumes

# ./oc_1_20 set -h
Configure application resources

 These commands help you make changes to existing application resources.

Available Commands:
  env            Update environment variables on a pod template
  image          Update image of a pod template
  resources      Update resource requests/limits on objects with pod templates
  selector       Set the selector on a resource
  serviceaccount Update ServiceAccount of a resource
  subject        Update User, Group or ServiceAccount in a RoleBinding/ClusterRoleBinding

Usage:
  kubectl set SUBCOMMAND [options]

[dry923]

Per our discussion on slack i'm closing this out as there is definitely something wrong w/ the binary of oc that I was using. Will reopen if needed.