Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies to requirements.txt and fix documentation #48

Merged
merged 1 commit into from Oct 26, 2021

Conversation

troy0820
Copy link
Contributor

Description

ReadME was referencing export_report.py instead of automation.py with report generation for after successful tests. This change fixes that documentation as well as update the dependencies that are necessary to run the reports.

Fixes

  • Documentation
    • Adds virtual environment for python generation reports
  • Dependencies
    • Adds necessary dependencies to requirements.txt
  • Adds ./env folder to .gitignore

@troy0820
Copy link
Contributor Author

I can add a Makefile target for the python adjustments if necessary.

Copy link
Member

@chentex chentex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @troy0820!

I think having it in the Makefile would not benefit us that much, since we would need to manage extra arguments in it.

@chentex chentex merged commit 9a92bd9 into cloud-bulldozer:main Oct 26, 2021
shahsahil264 pushed a commit to shahsahil264/ocm-api-load that referenced this pull request Jul 14, 2022
…irements

Add dependencies to requirements.txt and fix documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants