Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Workload Identity Support #1152

Closed
ericksod opened this issue May 25, 2023 Discussed in #1148 · 4 comments
Closed

Azure Workload Identity Support #1152

ericksod opened this issue May 25, 2023 Discussed in #1148 · 4 comments

Comments

@ericksod
Copy link
Contributor

Discussed in #1148

Perhaps it would be a good idea to start implementing Azure Workload Identity support, which is in line with future development of authentication between k8s resources and cloud resources, not only for Azure. This will also make future implementations much more secure since you do not have to worry about passing around client secrets for a user/spn that potentially has a lot of permissions within the cloud. Therefore, a huge win for security, and thus for future adoption. 😄

I believe we can achieve it by extending https://github.com/cloud-carbon-footprint/cloud-carbon-footprint/blob/trunk/packages/azure/src/application/AzureCredentialsProvider.ts in this fashion https://github.com/Azure/azure-workload-identity/blob/main/examples/azure-identity/node/index.js, shall I pick it up?

@tkennes
Copy link
Contributor

tkennes commented May 25, 2023

Sure, let me pick it up! :)

@tkennes
Copy link
Contributor

tkennes commented May 30, 2023

Hola @ericksod!

I've picked up the issue, but I'm a bit unsure how to properly test it. I'm a bit rusty with Yarn and Typescript. I do have an Azure environment where I can deploy it. I'll check later on the build, if you already have some feedback, let me know.

This should be it, can you give some feedback? #1158

@lukibahr
Copy link

Any news regarding this issue? I could check out the branch and test it on my Azure tenant, if required.

@4upz
Copy link
Member

4upz commented May 26, 2024

Any news regarding this issue? I could check out the branch and test it on my Azure tenant, if required.

Thanks for checking in on this, @lukibahr! This issue should be closed as it was resolved with the merging of #1158. Additional support for Managed Identity has been recently added with #1330 and will be included in the next release

@4upz 4upz closed this as completed May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants