Releng/fix CI and problems with type hints #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
slott56
commented
May 21, 2024
slott56
commented
- Use Poetry to rewrite pyproject.toml
- Use Poetry to manage dependencies
- Cleanup type hints (to an extent) to pass strict checks with mypy 1.10. Add a few type: ignore comments to be resolved later.
- Add COLUMNS setting to argparse testing
- Simplify tox.ini to streamline development
- Fix the CI setup to remove pre-commit, reset version numbers, and handle coverage upload.
- Remove disutils.version, replacing it with packaging.version
1. Use Poetry to rewrite pyproject.toml 2. Use Poetry to manage dependencies 3. Cleanup type hints (to an extent) to pass strict checks with mypy 1.10. Add a few type: ignore comments to be resolved later. 4. Add COLUMNS setting to argparse testing 5. Simplify tox.ini to streamline development
Switch to using ruff explicitly. Update environment list.
Also. Upgrade mypy to emphasize 3.12
kapilt
reviewed
May 21, 2024
| # Singleton word like "used" or "unused" abbreviates a longer expression: | ||
| c7n_filter = {"type": c7n_filter, "value": True} | ||
| c7n_filter = cast(Dict[str, Any], c7n_filter) | ||
| # c7n_filter = cast(Dict[str, Any], c7n_filter) |
There was a problem hiding this comment.
probably can just remove it seems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.