create cache folder if nonexistant #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
|
|
||
| def test_load(self): |
There was a problem hiding this comment.
this test can be nuked or implemented, but i'd rather not empty skeletons if only because it artificially inflates the test case count.
|
lgtm, one minor |
|
Cool. I'll remove that test |
Sutto
pushed a commit
to Sutto/cloud-custodian
that referenced
this pull request
May 26, 2021
…cryption Fix bug in checking bucket encryption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was having some problems with rebasing the out of sync PR/Branch so I just figured it would be easier to submit a new PR:
Fix for #16