Default CW Metrics timezone changed to UTC (#2106) #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapilt
reviewed
May 14, 2018
c7n/output.py
Outdated
| @@ -61,6 +61,12 @@ def __init__(self, ctx, namespace=DEFAULT_NAMESPACE): | |||
| self.namespace = namespace | |||
| self.buf = [] | |||
|
|
|||
| def get_timestamp(self): | |||
| if os.getenv("C7N_METRICS_TZ", '').upper() in ('TRUE', ''): | |||
There was a problem hiding this comment.
can we comment that this is a backwards compatibility flag, and reference the original issue.
kapilt
reviewed
May 14, 2018
tests/test_metric_tz.py
Outdated
|
|
||
| self.assertEqual(gts.minute,t1.minute) | ||
|
|
||
| os.environ["C7N_METRICS_TZ"] = 'TRUE' |
There was a problem hiding this comment.
just call change_environment(C7N_METRICS_TZ='TRUE') for environment changes.
tests/test_metric_tz.py
Outdated
|
|
||
| t1 = datetime.datetime.now() | ||
|
|
||
| os.unsetenv("C7N_METRICS_TZ") |
There was a problem hiding this comment.
don't need to do this, since change_environment will reset post test.
tests/test_metric_tz.py
Outdated
|
|
||
| mo = MetricsOutput(None) | ||
| c7nmetric = os.getenv("C7N_METRICS_TZ") | ||
|
|
There was a problem hiding this comment.
generally stylistically we don't blank new line for each line of code, its more about logical grouping in terms of when we blank newline for readability.
lamyanba
pushed a commit
to lamyanba/cloud-custodian
that referenced
this pull request
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please Merge.