Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve owner email handling #2843

Merged
merged 4 commits into from Sep 5, 2018
Merged

Improve owner email handling #2843

merged 4 commits into from Sep 5, 2018

Conversation

jaxxstorm
Copy link
Contributor

Currently, the only way to lookup an owner email address is via an OwnerContact tag or via LDAP.

This might be overkill in 2 scenarios:

  • An org uses SSO. In this case, the owner might already be an email address. This PR uses the existing target_is_email method to determine if an event-owner is already an email address, and if it is, use that address as the owner
  • Org AWS usernames match the email address for a user. This PR adds a configuration option, org_domain which will be appended to the aws_username with @ for the owner contact.

Lee Briggs added 3 commits September 4, 2018 15:43
Add global_org_email option
026633b
Refactor to be cleaner
482b809 
Add more logging output for debugging purposes
Add ability to send to username directly
6073f64 
If an org is using SSO of some kind, the username might already be an
email address.

Also updated the example.yml
@kapilt
Copy link
Collaborator

kapilt commented Sep 5, 2018

Thanks! All makes senses and sounds great.

@jaxxstorm
Copy link
Contributor Author

Awesome thanks @kapilt hoping to see this merged!

kapilt
kapilt reviewed Sep 5, 2018
View reviewed changes
Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, re changes, reducing the log verbosity of the output, and focusing log output on items with informational value to a reader, alot of it feels like branch dev logging that just needs cleanup .

tools/c7n_mailer/c7n_mailer/email_delivery.py Outdated Show resolved Hide resolved
tools/c7n_mailer/c7n_mailer/email_delivery.py Outdated Show resolved Hide resolved
tools/c7n_mailer/c7n_mailer/email_delivery.py Outdated Show resolved Hide resolved
tools/c7n_mailer/c7n_mailer/email_delivery.py Outdated Show resolved Hide resolved
kapilt
kapilt approved these changes Sep 5, 2018
View reviewed changes
Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@kapilt kapilt merged commit 0121d35 into cloud-custodian:master Sep 5, 2018
@kapilt kapilt mentioned this pull request Sep 27, 2018
Open
sampritavh pushed a commit to sampritavh/cloud-custodian that referenced this pull request Nov 22, 2018
@jaxxstorm @sampritavh
tools/c7n_mailer - improve event-owner email handling (cloud-custodia…
6f92cff 
…n#2843)
lamyanba pushed a commit to lamyanba/cloud-custodian that referenced this pull request Apr 23, 2019
@jaxxstorm
tools/c7n_mailer - improve event-owner email handling (cloud-custodia…
feb229c 
…n#2843)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapilt kapilt kapilt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jaxxstorm @kapilt