New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcp - add stack driver logging initial setup #3820
Conversation
b944d63
to
bd79995
Compare
88400e6
to
155217c
Compare
5546a63
to
6941b80
Compare
per comment in #4046, for any resource here implementing a get method, please also include a gcp api log test event to verify the assumptions being made about key structure of those events. |
23f265b
to
589f72f
Compare
Removed "log-monitored-resource-descriptor" resource, and updated all get methods |
Generally, logs are considered as confidential information. As a use case, Custodian can control 'syncs' which are used to export log entries to other destinations withing GCP project. Logs-based 'metrics' can also be used to extract values from logs and can be considered as sensitive data too. Custodian can control absence/existence of a certain metrics and their content: for example, to make sure that there are no metrics which include logs of specific types/labels/sources and automatically delete them (upon enabling of such an action later). |
Hello @kapilt can we move on with this pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe one of the get tests did not get updated with the event data and needs to be fixed
resource = p.run() | ||
self.assertEqual(len(resource), 1) | ||
|
||
def test_get_log_sink(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test doesn't seem to be utilizing the event data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made test through event data
Hello @kapilt, can we move on with this pr? any questions/concerns - please let us know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
Added initial classes with query and get functionality for projects sinks, sinks, metrics, log project, project, exclusions, log and monitored resource descriptors resources in Stackdriver logginig service