Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcp - add stack driver logging initial setup #3820

Merged
merged 7 commits into from Jul 31, 2019

Conversation

Dkhanas
Copy link
Contributor

@Dkhanas Dkhanas commented Apr 17, 2019

Added initial classes with query and get functionality for projects sinks, sinks, metrics, log project, project, exclusions, log and monitored resource descriptors resources in Stackdriver logginig service

@Dkhanas Dkhanas force-pushed the logging branch 2 times, most recently from b944d63 to bd79995 Compare April 17, 2019 11:55
@Dkhanas Dkhanas force-pushed the logging branch 4 times, most recently from 88400e6 to 155217c Compare April 23, 2019 15:01
@Dkhanas Dkhanas force-pushed the logging branch 2 times, most recently from 5546a63 to 6941b80 Compare May 2, 2019 08:43
@kapilt
Copy link
Collaborator

kapilt commented May 21, 2019

per comment in #4046, for any resource here implementing a get method, please also include a gcp api log test event to verify the assumptions being made about key structure of those events.

@Dkhanas Dkhanas force-pushed the logging branch 2 times, most recently from 23f265b to 589f72f Compare May 21, 2019 15:28
@Dkhanas
Copy link
Contributor Author

Dkhanas commented May 22, 2019

Removed "log-monitored-resource-descriptor" resource, and updated all get methods

@Dkhanas
Copy link
Contributor Author

Dkhanas commented Jun 13, 2019

Generally, logs are considered as confidential information. As a use case, Custodian can control 'syncs' which are used to export log entries to other destinations withing GCP project. Logs-based 'metrics' can also be used to extract values from logs and can be considered as sensitive data too. Custodian can control absence/existence of a certain metrics and their content: for example, to make sure that there are no metrics which include logs of specific types/labels/sources and automatically delete them (upon enabling of such an action later).

@Dkhanas
Copy link
Contributor Author

Dkhanas commented Jun 24, 2019

Hello @kapilt can we move on with this pr?

Copy link

@jondavidi jondavidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe one of the get tests did not get updated with the event data and needs to be fixed

resource = p.run()
self.assertEqual(len(resource), 1)

def test_get_log_sink(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test doesn't seem to be utilizing the event data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made test through event data

@aleonidex
Copy link

Hello @kapilt, can we move on with this pr? any questions/concerns - please let us know.

Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@kapilt kapilt merged commit 1637b7b into cloud-custodian:master Jul 31, 2019
fidelito pushed a commit to fidelito/cloud-custodian that referenced this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants