azure - Update key replace code & rerecord cassettes #4272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefangordon
approved these changes
Jun 27, 2019
| @@ -190,6 +191,7 @@ def _response_callback(self, response): | |||
| body = AzureVCRBaseTest._replace_tenant_id(body) | |||
| body = AzureVCRBaseTest._replace_subscription_id(body) | |||
| body = AzureVCRBaseTest._replace_storage_keys(body) | |||
| body = AzureVCRBaseTest._replace_instrumentation_key(body) | |||
There was a problem hiding this comment.
At some point I guess we should just lift the whole azure common test bits - they do a more robust plugin model here to register cassette modifications like this.
fidelito
pushed a commit
to fidelito/cloud-custodian
that referenced
this pull request
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update secrets replace code & rerecord cassettes
closes #4117