Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws - sg ingress/egress fixes #4292

Merged
merged 5 commits into from Aug 10, 2019
Merged

aws - sg ingress/egress fixes #4292

merged 5 commits into from Aug 10, 2019

Conversation

kapilt
Copy link
Collaborator

@kapilt kapilt commented Jun 29, 2019 •
edited

closes #4275

  • allow ipprotocol use string version of -1, previously this allowed the negative integer -1 which didn't match the attribute value of the security group which was a string.
  • Ports are exposed on egress permission
  • FromPort/ToPort support specifying a value type filter syntax for fuller range comparisons.

@kapilt kapilt changed the title aws - sg ingress/egress ipprotocol use string version of -1 aws - sg ingress/egress fixes Jun 29, 2019
@kapilt kapilt mentioned this pull request Jul 31, 2019
Open
@kapilt kapilt merged commit f4b0224 into cloud-custodian:master Aug 10, 2019
fidelito pushed a commit to fidelito/cloud-custodian that referenced this pull request May 29, 2020
@kapilt @fidelito
aws - sg ingress/egress filter fixes (cloud-custodian#4292)
cacbb1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefangordon stefangordon stefangordon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

security group egress filter not behaving as expected
2 participants
@kapilt @stefangordon