Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP Actions. Load balancer - SSL Policies. Delete #4345

Merged
merged 9 commits into from Jul 30, 2019
Merged

GCP Actions. Load balancer - SSL Policies. Delete #4345

merged 9 commits into from Jul 30, 2019

Conversation

evhenyshaliov
Copy link
Collaborator

Added

  • implemetation
  • docstrings
  • example
  • unit test

kapilt
kapilt previously approved these changes Jul 10, 2019
View reviewed changes
Copy link
Collaborator

@kapilt kapilt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

[update] please update to handle merge conflicts, and I'll look over again.

@kapilt kapilt dismissed their stale review July 10, 2019 14:00

merge conflicts need to be resolved first

@evhenyshaliov
Copy link
Collaborator Author

evhenyshaliov commented Jul 11, 2019 •
edited

Thank you. The merge conflicts were resolved. Please check.
New failed tests appeared after merge. The tests are out of the PR's scope.

kapilt
kapilt approved these changes Jul 30, 2019
View reviewed changes
Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kapilt kapilt merged commit 0fa41b9 into cloud-custodian:master Jul 30, 2019
fidelito pushed a commit to fidelito/cloud-custodian that referenced this pull request May 29, 2020
@evhenyshaliov @fidelito
gcp - load balancer policy delete action (cloud-custodian#4345)
fde8a33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapilt kapilt kapilt approved these changes

Assignees
No one assigned
Labels
provider/gcp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evhenyshaliov @kapilt