azure - Update azure-functions #4364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapilt
reviewed
Jul 11, 2019
| @@ -17,7 +17,7 @@ | |||
| import unittest | |||
|
|
|||
| try: | |||
| from azure.functions_worker.bindings.queue import QueueMessage | |||
| from azure.functions.queue import QueueMessage | |||
There was a problem hiding this comment.
why is this in a try/except import block in a unit test?
There was a problem hiding this comment.
nevermind the the ci failure indicates due to not working on python 2.7
There was a problem hiding this comment.
in general the blanket catch on import errors should be localized to python 2.7 so that the other runtimes actually throw properly on errors.
tools/c7n_azure/setup.py
Outdated
| @@ -70,6 +70,7 @@ | |||
| "azure-mgmt-eventgrid", | |||
| "azure-mgmt-logic", | |||
| "azure-cosmos", | |||
| "azure-functions", | |||
There was a problem hiding this comment.
I don't think we do this as it only works in 3.6/3.7 and isn't needed here.
stefangordon
approved these changes
Jul 11, 2019
aluong
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some refactoring in azure-functions-worker library and old code stopped working.
addresses #4363