Rds elb tags #44
Rds elb tags #44
Conversation
|
need to fix tests here |
| chunks = [elb_names[x:x+20] for x in xrange(0, len(elb_names), 20)] | ||
| fn = partial(self.process_tags, client=client) | ||
| with self.executor_factory(max_workers=3) as w: | ||
| tags = w.map(fn, chunks) |
There was a problem hiding this comment.
there's a corner case here that makes it preferential to use the submit syntax instead of map, namely an elb being removed between the query of the elbs to querying its tags would fail the entire policy instead of the batch.
|
Comments addressed and rebased. Please review again when you can. |
| the result set. | ||
| """ | ||
| elb_names = [elb['LoadBalancerName'] for elb in elbs] | ||
| names_to_tags = {} |
There was a problem hiding this comment.
don't really think you need the names_to_tag map, you could just chunk the elbs and let the process_tags function directly update the elb, don't really need the result as its mutating a shared ref with transient ownership, just the exception processing.
that said there's requests for this now, so happy to cleanup after the fact post merge.
There was a problem hiding this comment.
fair enough - thanks for reviewing
|
lgtm, thanks |
Added tag support for RDS and ELB - #35 and #40. Did these together since they were pretty similar.
Approach to get RDS ARN was to just grab a security group from the account and get the ARN as suggested http://stackoverflow.com/questions/32634402/work-with-rds-tags-in-boto3-how-to-get-arn-in-boto3. This is a bit hacky. I saw your note on maybe using an attribute for account - that could be a next pass, but I think the SG way will work for a first pass.