aws | missing launch template

[PratMis]

Closes #4568

Added a try/except block around describe_launch_template_versions api call. Continues if the launch template is not found and raises in all other cases

[PratMis]

Might have to put in a test case I guess. If this looks good @kapilt, I can get the tests in! Thanks

[kapilt]

approach looks fine wrt to api exception, but there's some additional behavior validation needed around the filter itself, ie if attribute equality check on launch template that doesn't exist shouldn't return results for non existent. also brings up the another question of how do you check for an asg with a non existent launch template version, ideally that would be handled by the invalid asg filter check but the correctness depends in part on behavior here I suspect.

[PratMis]

Cool, I'll try to add those changes in! Thanks

[PratMis]

Hello @kapilt! I have added some code:
Added an exception handler for non existent launch template id version
Looking into the invalid filter, had missed your edited comment

[kapilt]

needs some additional test coverage on the exception handling behavior, if you need an example of injecting clients with failures, patch or mock is appropriate, there are other resource tests doing the same.

[PratMis]

Thanks for your input! I'll get the test cases out such that the codecov goes up. Right now looks like its not respecting the test I wrote as per your suggestion.
Also, I looked into the invalid filter. From what I understand, we can return an ASG as invalid if the launch template/launch-template-version it is tied to doesn't exist. But that wouldn't help in this case as it would make the logic redundant.

Update: For testing, used two (lt, lt-version) tuples. One of them doesn't exist. Passed the arguments through get_resources() in class LaunchTemplate. Even if one of them doesn't exist, the exception was handled and the results returned as expected. Thanks for your help!

[kapilt]

thanks, lgtm