aws.vpc | set-flow-log | DeliverLogsPermissionArn not required with DestinationType as s3 #4666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PratMis
changed the title
PratMis
changed the title
PratMis
changed the title
kapilt
reviewed
Aug 27, 2019
|
closing this in favor of the refactoring in #4759 that also simplifies validation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4641
Earlier, DeliverLogsPermissionArn attribute was required when creating flow-log with any destination(cloud-watch-logs or s3). Looks like now they don't require DeliverLogsPermissionArn when LogDestinationType is S3.
Document: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2.html#EC2.Client.create_flow_logs