Azure - Add mailer support to the Container Host helm chart #4711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -94,18 +96,19 @@ def sendgrid_handler(self, queue_message, to_addrs_to_email_messages_map): | |||
|
|
|||
| for email_to_addrs, message in six.iteritems(to_addrs_to_email_messages_map): | |||
| for to_address in email_to_addrs: | |||
| message_string = base64.b64decode(message.get_payload()).decode('utf-8') | |||
There was a problem hiding this comment.
Will follow up offline about this. We should use sendgrids Mail.from_emailmessage() method and replace most of this code.
There was a problem hiding this comment.
It wasn't quite as easy as calling Mail.from_EmailMessage. So, I copied that function at the bottom of this file and made some changes.
- I think SendGrid has a bug in that call which is fixed by creating a
Toobject instead of anEmailobject when calling the Mail constructor. - We set a number of headers on the message object that break the SendGrid API (they are reserved keys), so I ignore those headers when copying the headers over. more info
stefangordon
approved these changes
Sep 3, 2019
fidelito
pushed a commit
to fidelito/cloud-custodian
that referenced
this pull request
May 29, 2020
…stodian#4711) * fix email content for sendgrid * mailer support for helm chart * update sendgrid email sdk * update deployment script to read a values file * cleanup deployment script * update docs * show more helm output * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4680
Add support for deploying c7n_mailer's docker image along with the container host through the helm chart. The mailer is deployed as a Kubernetes CronJob, and a custom cron schedule can be specified.
Other Fixes