azure - event_subscription functional test fix #4757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logachev
approved these changes
Sep 10, 2019
fidelito
pushed a commit
to fidelito/cloud-custodian
that referenced
this pull request
May 29, 2020
* Fixed failure in test_event_subscriptions nightly run * Updated test and deleted cassette * Changed format of tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: The bug would occur in the testing suite when the AzureEventsTest class would run before AzureEventSubscripitonsTest class.
An event subscription would be created in the test_create_azure_event_subscription function. While it was being provisioned, the AzureEventSubscripitonsTest would attempt to update this event subscription causing a failure because it was not provisioned yet.
Fix: This fix patches the create call in the test_create_azure_event_subscription so an event grid subscription is not being created, and does not interfere with the AzureEventSubscripitonsTest suite.
There is no need for a cassette file because the API call is now patched, and mock data is used for the StorageQueueEventSubscription